Skip to content

test: add PostgreSQL TPC-H integration tests#855

Open
bestbeforetoday wants to merge 4 commits into
substrait-io:mainfrom
bestbeforetoday:tpch-reference-tests
Open

test: add PostgreSQL TPC-H integration tests#855
bestbeforetoday wants to merge 4 commits into
substrait-io:mainfrom
bestbeforetoday:tpch-reference-tests

Conversation

@bestbeforetoday

@bestbeforetoday bestbeforetoday commented Jun 8, 2026

Copy link
Copy Markdown
Member

Extends the changes in #700 to generate TPC-H data on demand during test execution and avoid checking in large amounts of test data.

Signed-off-by: Niels Pardon <par@zurich.ibm.com>
@bestbeforetoday bestbeforetoday marked this pull request as ready for review June 8, 2026 18:44
@bestbeforetoday bestbeforetoday changed the title feat: add PostgreSQL TPC-H integration tests test: add PostgreSQL TPC-H integration tests Jun 8, 2026
Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Comment on lines +41 to +42
// TODO: These queries produce different results when generated from Substrait
private static final List<Integer> EXCLUDED_QUERIES = List.of(14);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting that query 14 is not producing the same result for you while for my PR with the static data it was query 21 that was not producing the same result

@bestbeforetoday bestbeforetoday Jun 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Calcite version has been bumped up between those two PRs. Possibly that has made a difference.

I notice that with larger scale factors more failure start to appear. I suspect this might be due to resource constraints in the containerized test environment so stuck to a small scale factor. It might also be that a larger variety of data shows up edge case failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants